all: replace calls to errors.As with errors.AsType #75698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

jub0bs wants to merge 1 commit into golang:master from jub0bs:remove-errorsas-calls

+160 −180

Contributor

jub0bs commented Oct 1, 2025

This change replaces most occurrences (in code as well as in comments) of
errors.As with errors.AsType. It leaves the errors package and vendored
code untouched.


          all: replace calls to errors.As with errors.AsType

8aaaa36

austinderek mentioned this pull request

all: replace calls to errors.As with errors.AsType PullRequestInc/go#93

Closed

Contributor

gopherbot commented Oct 1, 2025

This PR (HEAD: 8aaaa36) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/708495.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Oct 1, 2025

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 1, 2025

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

jub0bs mentioned this pull request

x/tools/go/analysis/passes/modernize: errorsastype: modernize errors.As -> errors.AsType #75692

Open

Contributor

gopherbot commented Oct 1, 2025

Message from Jake Bailey:

Patch Set 1: Commit-Queue+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 1, 2025

Message from Go LUCI:

Patch Set 1:

Dry run: CV is trying the patch.

Bot data: {"action":"start","triggered_at":"2025-10-01T20:42:58Z","revision":"e3014fed003bfcc2d68e07c4fcca8a5dc83b5d40"}

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 1, 2025

Message from Jake Bailey:

Patch Set 1: -Commit-Queue

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 1, 2025

Message from Go LUCI:

Patch Set 1:

This CL has passed the run

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 1, 2025

Message from Go LUCI:

Patch Set 1: LUCI-TryBot-Result+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 2, 2025

Message from jub0bs:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Oct 12, 2025

Message from Alan Donovan:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/708495.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          all: replace calls to errors.As with errors.AsType

6bcd97d

This change replaces most occurrences (in code as well as in comments) of
errors.As with errors.AsType. It leaves the errors package and vendored
code untouched.

Change-Id: I3bde73f318a0b408bdb8f5a251494af15a13118a
GitHub-Last-Rev: 8aaaa36
GitHub-Pull-Request: #75698
Reviewed-on: https://go-review.googlesource.com/c/go/+/708495
Auto-Submit: Michael Pratt <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Alan Donovan <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>

Contributor

gopherbot commented Oct 13, 2025

This PR is being closed because golang.org/cl/708495 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet